RSA OAEP Support #303
Merged
RSA OAEP Support #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 95.82% 95.79% -0.04%
==========================================
Files 60 61 +1
Lines 7865 8128 +263
==========================================
+ Hits 7537 7786 +249
- Misses 328 342 +14 ☔ View full report in Codecov by Sentry. |
skmcgrail
force-pushed
the
oaep
branch
2 times, most recently
from
4f93e92
to
2035ea0
Compare
skmcgrail
commented
Dec 21, 2023
justsmth
reviewed
Jan 2, 2024
justsmth
reviewed
Jan 3, 2024
skmcgrail
force-pushed
the
oaep
branch
7 times, most recently
from
bbb7d8f
to
83a9e8c
Compare
justsmth
reviewed
Jan 18, 2024
|
Moving this to draft for the time being. Currently splitting out the key generation from the OAEP support to reduce the feature scope for our next release. |
justsmth
reviewed
Feb 16, 2024
justsmth
reviewed
Apr 8, 2024
There was a problem hiding this comment.
There are CI failures for clippy and semver. I'm not worried about clippy, but for semver we'll need to add back a rsa::KeySize::len before release.
Otherwise, it looks great!
justsmth
reviewed
Apr 9, 2024
justsmth
reviewed
Apr 9, 2024
justinwsmith
approved these changes
Apr 9, 2024
justsmth
previously approved these changes
Apr 9, 2024
andrewhop
reviewed
Apr 9, 2024
andrewhop
previously approved these changes
Apr 10, 2024
justsmth
reviewed
Apr 10, 2024
justsmth
previously approved these changes
Apr 10, 2024
justsmth
approved these changes
Apr 10, 2024
andrewhop
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implements support for RSA OAEP encryption and decryption to support usage in a broader key-transport scheme. Additionally adds support for RSA key generation (#296).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.