RSA Key Generation Support #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 95.91% 96.00% +0.09%
==========================================
Files 60 61 +1
Lines 8522 8767 +245
==========================================
+ Hits 8174 8417 +243
- Misses 348 350 +2 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Jan 22, 2024
justsmth
previously approved these changes
Jan 22, 2024
justsmth
approved these changes
Jan 23, 2024
justsmth
previously approved these changes
Jan 24, 2024
justsmth
previously approved these changes
Jan 24, 2024
justsmth
previously approved these changes
Jan 25, 2024
justsmth
approved these changes
Jan 25, 2024
skmcgrail
requested review from
samuel40791765
and removed request for
andrewhop
samuel40791765
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #296
Description
Implements RSA KeyPair generation. This takes the relevant parts from #303 without the OAEP support and the much broader refactor of the underlying RSA code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.