Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV vars for OPENSSL_NO_ASM #377

Merged
merged 2 commits into from
Apr 26, 2024
Merged

ENV vars for OPENSSL_NO_ASM #377

merged 2 commits into from
Apr 26, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 1, 2024

Issues:

Description of changes:

  • AWS-LC contains optimized assembly language implementations for many primitive cryptographic operations. As a fall-back, these operations also have a C-implementation provided.
  • For most platforms, CMake correctly detects whether/which assembly files should be built. However, CMake's detection is sometimes inadequate or the build environment lacks an assembler (such as NASM), and the OPENSSL_NO_ASM flag must be passed to avoid build failures.
  • The OPENSSL_NO_ASM flag may also be useful for debugging failing cryptographic operations.

Call-outs:

  • The C-implementations are significantly slower than their assembly-language counterparts.
  • The OPENSSL_NO_ASM flag is only allowed for un-optimized/debug builds.

Testing:

  • Updated CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner April 1, 2024 14:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (972db16) to head (2d7fdb0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          60       60           
  Lines        7865     7865           
=======================================
  Hits         7537     7537           
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as draft April 1, 2024 23:05
@justsmth justsmth force-pushed the sys-no-asm-env branch 4 times, most recently from 048bdcf to ff8161a Compare April 2, 2024 15:06
@justsmth justsmth marked this pull request as ready for review April 2, 2024 15:22
@justsmth justsmth force-pushed the sys-no-asm-env branch 2 times, most recently from 2d7fdb0 to 999004c Compare April 4, 2024 16:05
@justsmth justsmth force-pushed the sys-no-asm-env branch 6 times, most recently from 99d2c93 to b7c8072 Compare April 26, 2024 12:58
@justsmth justsmth merged commit de5c627 into aws:main Apr 26, 2024
176 of 184 checks passed
@justsmth justsmth deleted the sys-no-asm-env branch April 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants