Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cmake toolchain env #431

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

justsmth
Copy link
Contributor

Issues:

Resolves #376

Description of changes:

  • cargo-xwin is a build tool for "Cross compil[ing a] Cargo project to Windows msvc target with ease".
  • cargo-xwin sets a CMAKE_TOOLCHAIN_FILE_*_pc_windows_msvc environment variable to provide CMake guidance on the compiler setup. We should avoid overriding the configuration it provides.

Testing:

  • Adds a CI job to verify that we can build for the *_pc_windows_msvc targets from an Ubuntu host.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the allow-cmake-toolchain-env branch 6 times, most recently from 4f6b29b to ce9ef81 Compare May 31, 2024 19:42
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (c358484) to head (ca9eb35).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       61              
  Lines        8143     8174      +31     
  Branches        0     8174    +8174     
==========================================
- Hits         7801     7575     -226     
- Misses        342      357      +15     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the allow-cmake-toolchain-env branch 5 times, most recently from 9ffc45b to 53abd42 Compare June 3, 2024 20:57
@justsmth justsmth force-pushed the allow-cmake-toolchain-env branch from 53abd42 to ca9eb35 Compare June 3, 2024 21:14
@justsmth justsmth marked this pull request as ready for review June 3, 2024 21:15
@justsmth justsmth requested a review from a team as a code owner June 3, 2024 21:15
@justsmth justsmth merged commit cd34120 into aws:main Jun 5, 2024
187 checks passed
@justsmth justsmth deleted the allow-cmake-toolchain-env branch June 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed at target: aarch64-pc-windows-msvc
4 participants