-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-lc-sys, align w/ AWS-LC v1.34.2 #509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 95.80% 92.52% -3.28%
==========================================
Files 61 67 +6
Lines 8143 9277 +1134
Branches 0 9277 +9277
==========================================
+ Hits 7801 8584 +783
- Misses 342 422 +80
- Partials 0 271 +271 ☔ View full report in Codecov by Sentry. |
f785176
to
ecf0b5e
Compare
ecf0b5e
to
99c6931
Compare
let cstd = match val.as_str() { | ||
"99" => CStdRequested::C99, | ||
"11" => CStdRequested::C11, | ||
_ => CStdRequested::None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's something we can't parse should this be a hard error? If someone set AWS_LC_SYS_C_STD=c11
it would hit none here, and then could they actually get c99, or vice versa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought about matching against a RegExp here to add more flexibility, but I'm not sure it's worth the trouble.
I see this environment variable as something that will rarely be needed. We will default to C11 for most consumers (which should work for any build host that's been setup sometime in the last decade).
Is it possible to update |
Unfortunately, When we update our MSRV again, we plan to also update many of our dependencies to more recent versions. |
Description of changes:
AWS_LC_SYS_C_STD
environment variable to determine which C standard to use.Call-outs:
CRYPTO_refcount_dec_and_test_zero
orCRYPTO_refcount_inc
symbols. We need these symbols to be prefixed for C99 build. Thus, for some targets in the symbol collection step of the automation are being forced to use a C99 build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.