Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-lc-sys, align w/ AWS-LC v1.34.2 #509
Update aws-lc-sys, align w/ AWS-LC v1.34.2 #509
Changes from all commits
762461f
5610e72
6d5f053
01e0b7b
b214573
4d34581
149e09e
6607ef8
3141a0f
20453d9
8a120e6
05d9803
97197be
389e213
f8be186
387f351
5b3412d
d22275b
e29de62
eaffacd
a61e35b
068e3ec
0f81e16
d97e5b8
d7bf059
a27d999
29619fb
b8d7033
d4b985c
3f8971d
7665df6
1c526bf
d9368be
f30919d
b58fb89
99c6931
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's something we can't parse should this be a hard error? If someone set
AWS_LC_SYS_C_STD=c11
it would hit none here, and then could they actually get c99, or vice versa.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought about matching against a RegExp here to add more flexibility, but I'm not sure it's worth the trouble.
I see this environment variable as something that will rarely be needed. We will default to C11 for most consumers (which should work for any build host that's been setup sometime in the last decade).