Make dispatch tests use corruptible registers on aarch64. #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
approved these changes
Jul 27, 2023
billbo-yang
approved these changes
Jul 27, 2023
billbo-yang
pushed a commit
to billbo-yang/aws-lc
that referenced
this pull request
Jul 31, 2023
Using registers x6 and x7 is risky because they can be used for input parameters. Switching the dispatch tests to use x9 and x10 which are corruptible regitsters.
Merged
billbo-yang
added a commit
that referenced
this pull request
Aug 1, 2023
* Add BoringSSL Dispatch Test for aarch64 * Make dispatch tests use corruptible registers on aarch64. (#1118) * Support changing OPENSSL_armcap with environment variable on Apple 64-bit ARM systems (#1045) * use handle_cpu_env from cpu_aarch64_linux.c to cpu_aarch64_apple.c * always use OPENSSL_armcap() when detecting hardware capabilities on arm * fix device farm CI build with boto3 (#990) --------- Co-authored-by: Bill Yang <wbyang@amazon.com> Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com> Co-authored-by: Samuel Chiang <sachiang@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-1873
Follow-up on PR #1093
Description of changes:
Using registers x6 and x7 is risky because they can be used for input parameters.
Switching the dispatch tests to use x9 and x10 which are corruptible regitsters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.