Move OPENSSL_armcap changes and aarch64 dispatch tests to 1MU #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using registers x6 and x7 is risky because they can be used for input parameters. Switching the dispatch tests to use x9 and x10 which are corruptible regitsters.
…-bit ARM systems (aws#1045) * use handle_cpu_env from cpu_aarch64_linux.c to cpu_aarch64_apple.c * always use OPENSSL_armcap() when detecting hardware capabilities on arm * refactor duplicated into cpu_aarch64.h/c * add ifdefs to cpu_aarch64.h/c * Update comments Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com> * adjust line length of comment * set arm capabilities functions to fillow format of x86 ones * make rest of the arm capability functions in line with x86 ones --------- Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com> Co-authored-by: Bill Yang <wbyang@amazon.com>
billbo-yang
force-pushed
the
fips-2021-10-20-1MU
branch
from
edaaed0 to
55d988e
Compare
darylmartin100
approved these changes
Aug 1, 2023
nebeid
approved these changes
Aug 1, 2023
skmcgrail
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves CryptoAlg-1873
Addresses CryptoAlg-1764
Description of changes:
Moves changes from PRs #1093, #1118, and #1045 into the 1MU branch
It also contains d723334, to fix the devicefarm CI failure on the 1MU branch since it hasn't been pulled in yet
Call-outs:
For the dispatch tests, I had to remove tests for capabilities we don't have in the 1MU branch (e.g. lots of the arm GCM stuff)
Testing:
Tests pass locally on aarch64 M1 mac and x86 Ubuntu
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.