Give BIO an ex_data #1328
Merged
Give BIO an ex_data #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder to merge commit, no squash |
torben-hansen
previously approved these changes
Nov 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
+ Coverage 76.46% 76.47% +0.01%
==========================================
Files 421 421
Lines 70986 70996 +10
==========================================
+ Hits 54280 54297 +17
+ Misses 16706 16699 -7 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Nov 29, 2023
justsmth
previously approved these changes
Nov 30, 2023
torben-hansen
previously approved these changes
Nov 30, 2023
samuel40791765
dismissed stale reviews from torben-hansen and justsmth
via
7932032
samuel40791765
force-pushed
the
postgres-commit
branch
from
d0079f7
to
7932032
Compare
It has one in upstream OpenSSL. The most recent OpenSSL release is hitting a compatibility issue with postgres, which seems like it'll get fixed by postgres using BIO_get_app_data. Add it on our end too. https://www.postgresql.org/message-id/CAN55FZ1eDDYsYaL7mv%2BoSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ%40mail.gmail.com Homebrew/homebrew-core#155651 Change-Id: I5bf226cc3506a114cd62f885a8c15006512dfc65 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64227 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com> (cherry picked from commit 2139aba2e3e28cd1cdefbd9b48e2c31a75441203)
samuel40791765
force-pushed
the
postgres-commit
branch
from
7932032
to
c5b7335
Compare
torben-hansen
approved these changes
Nov 30, 2023
skmcgrail
approved these changes
Dec 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixing postgres compatibility
Description
It has one in upstream OpenSSL. The most recent OpenSSL release is hitting a compatibility issue with postgres, which seems like it'll get fixed by postgres using BIO_get_app_data. Add it on our end too.
https://www.postgresql.org/message-id/CAN55FZ1eDDYsYaL7mv%2BoSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ%40mail.gmail.com Homebrew/homebrew-core#155651
Change-Id: I5bf226cc3506a114cd62f885a8c15006512dfc65 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64227
Auto-Submit: David Benjamin davidben@google.com
Reviewed-by: Bob Beck bbe@google.com
Commit-Queue: Bob Beck bbe@google.com
(cherry picked from commit 2139aba2e3e28cd1cdefbd9b48e2c31a75441203)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.