Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give X509_STORE an ex_data #1583

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

samuel40791765
Copy link
Contributor

Issues:

Resolves CryptoAlg-1648

Description of changes:

X509_STORE has an ex_data upstream and Ruby happens to consume this. This is mostly following the work done in #1328

Call-outs:

N/A

Testing:

New test for ex_data

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

(cherry picked from commit 76d0f56d2b8920cce25931e921c05ed937cffda0)
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.92%. Comparing base (8ae155b) to head (a220620).

Files Patch % Lines
crypto/x509/x509_lu.c 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1583   +/-   ##
=======================================
  Coverage   77.91%   77.92%           
=======================================
  Files         560      560           
  Lines       94614    94629   +15     
  Branches    13619    13618    -1     
=======================================
+ Hits        73719    73735   +16     
+ Misses      20299    20298    -1     
  Partials      596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torben-hansen torben-hansen self-requested a review May 9, 2024 22:48
@samuel40791765 samuel40791765 merged commit 7ef93cb into aws:main May 14, 2024
79 checks passed
@samuel40791765 samuel40791765 deleted the x509-ex-data branch May 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants