Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): ts-ignore packageInfo imports in codegen #2875

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

adamthom-amzn
Copy link
Contributor

Description

This applies the API made available in smithy-lang/smithy-typescript#445 and regenerates clients.

Testing

Ran the newly-generated protocol tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Avoids postprocessing generated clients in favor of ignoring the import at
codegen time.
Uses generation-time ts-ignore on packageInfo imports.
@adamthom-amzn adamthom-amzn requested a review from a team October 6, 2021 17:47
@codecov-commenter
Copy link

Codecov Report

Merging #2875 (68f2230) into main (10d64df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2875   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         554      554           
  Lines       28886    28886           
  Branches     7072     7072           
=======================================
  Hits        17453    17453           
  Misses      11433    11433           
Impacted Files Coverage Δ
clients/client-sts/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/src/runtimeConfig.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json-10/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...lients/client-mediastore-data/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ts/client-lex-runtime-service/src/runtimeConfig.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d64df...68f2230. Read the comment docs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants