Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use exact @aws-sdk/* dependencies on top of beta.3 #1109

Closed
wants to merge 2 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 27, 2020

Issue #, if available:
Alternative to #1108 for one-off beta.5 release to unblock Amplify

Description of changes:
uses exact @aws-sdk/* dependencies on top of beta.3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr added 2 commits April 27, 2020 02:32
Search key: "@aws-sdk/([^"]*)": "\^1.0.0-beta.([\d])”
Replace key: "@aws-sdk/$1": "1.0.0-beta.$2"
in package.json
@trivikr trivikr changed the title feat: use exact @aws-sdk/* dependencies feat: use exact @aws-sdk/* dependencies on top of beta.3 Apr 27, 2020
@AllanZhengYP
Copy link
Contributor

If we release with only removing the ^ in the package.json files from beta.3 release without any other change, Lerna will bump the packages into the versions that already released in beta.4 release. For example @aws-sdk/config-resolver bumped from 1.0.0-beta.2 to 1.0.0-beta.3 in release beta.3. If we checkout from beta.3 release and do another release, the package will be bumped to the same 1.0.0-beta.3 again and fails the release, depite we intended to release 1.0.0-beta.4.

To fix this, we will investigate copying the package.json files from beta.4 release and bump the packages to next version, in beta.5 release. Although the code is from beta.3 release.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (one-off-beta-5@a239010). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             one-off-beta-5    #1109   +/-   ##
=================================================
  Coverage                  ?   91.43%           
=================================================
  Files                     ?      145           
  Lines                     ?     2850           
  Branches                  ?      506           
=================================================
  Hits                      ?     2606           
  Misses                    ?      244           
  Partials                  ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a239010...4a43db3. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 4a43db3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Apr 27, 2020

Closing as lerna publish would fail as per #1109 (comment)
Succeeded by #1110

@trivikr trivikr closed this Apr 27, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@trivikr trivikr deleted the one-off-beta-5-pr branch June 5, 2020 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants