Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(clients): populate variants in endpoints hashes #2957

Closed
wants to merge 16 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 29, 2021

Issue

Follow-up to #2947

Description

Populates variants in endpoints hashes.

Testing

N/A as variants are additive.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #2957 (96a4e45) into config-fips-dualstack (1348a15) will not change coverage.
The diff coverage is n/a.

❗ Current head 96a4e45 differs from pull request most recent head b7d7d82. Consider uploading reports for the commit b7d7d82 to get more accurate results
Impacted file tree graph

@@                  Coverage Diff                   @@
##           config-fips-dualstack    #2957   +/-   ##
======================================================
  Coverage                  58.68%   58.68%           
======================================================
  Files                        564      564           
  Lines                      30325    30325           
  Branches                    7472     7472           
======================================================
  Hits                       17795    17795           
  Misses                     12530    12530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1348a15...b7d7d82. Read the comment docs.

@trivikr trivikr changed the title chore(clients): populate variants in endpoints hashes [WIP] chore(clients): populate variants in endpoints hashes Nov 1, 2021
@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2021

Superceded by #2962

@trivikr trivikr closed this Nov 1, 2021
@trivikr trivikr deleted the regionInfo-variants branch November 1, 2021 18:39
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants