Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): add config for fips and dualStack endpoint #2947

Merged
merged 13 commits into from
Nov 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 28, 2021

Issue

Internal JS-2905
Internal JS-2906

Note: This PR will be made ready once fix in #2945 is merged.

Description

Adds useFipsEndpoint configuration:

  • Can be passed as a boolean or Provider<boolean> in client configuration.
  • Defaults to false.
  • Reads from following places for Node.js
    • env["AWS_USE_FIPS_ENDPOINT"]
    • profile["use_fips_endpoint"]

Adds useFipsEndpoint configuration:

  • Can be passed as a boolean or Provider<boolean> in client configuration.
  • Defaults to false.
  • Reads from following places for Node.js
    • env["AWS_USE_DUALSTACK_ENDPOINT"]
    • profile["use_dualstack_endpoint"]

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #2947 (17838e1) into main (abe4ed9) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
+ Coverage   58.60%   58.68%   +0.07%     
==========================================
  Files         561      564       +3     
  Lines       30272    30325      +53     
  Branches     7452     7472      +20     
==========================================
+ Hits        17742    17795      +53     
  Misses      12530    12530              
Impacted Files Coverage Δ
...s/middleware-bucket-endpoint/src/configurations.ts 69.23% <0.00%> (-0.77%) ⬇️
clients/client-sts/src/STSClient.ts 92.59% <0.00%> (ø)
clients/client-sts/src/runtimeConfig.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/runtimeConfig.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/S3ControlClient.ts 93.33% <0.00%> (ø)
private/aws-protocoltests-ec2/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...lients/client-mediastore-data/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...rivate/aws-protocoltests-json/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ivate/aws-protocoltests-query/src/runtimeConfig.ts 100.00% <0.00%> (ø)
...ate/aws-protocoltests-ec2/src/EC2ProtocolClient.ts 92.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe4ed9...17838e1. Read the comment docs.

@trivikr trivikr force-pushed the config-fips-dualstack branch from 28bb878 to 1348a15 Compare October 29, 2021 15:06
@trivikr trivikr requested a review from AllanZhengYP October 29, 2021 15:18
@trivikr trivikr marked this pull request as ready for review October 29, 2021 15:18
@trivikr trivikr force-pushed the config-fips-dualstack branch from 8f8e5a5 to f53b39e Compare November 1, 2021 16:44
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants