Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-config-provider): move booleanSelector util to platform agnostic package #2992

Merged
merged 6 commits into from
Nov 5, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 5, 2021

Issue

Resolves: #2993

Description

Moves booleanSelector util to platform agnostic package util-config-provider

The booleanSelector contains platform-agnostic code, and it shouldn't be added in Node.js specific node-config-provider.

Testing

  • Unit testing
  • Integration testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP November 5, 2021 19:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #2992 (315d54b) into main (e45d8ee) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 315d54b differs from pull request most recent head bbf7037. Consider uploading reports for the commit bbf7037 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   58.77%   58.77%           
=======================================
  Files         567      567           
  Lines       30364    30364           
  Branches     7483     7483           
=======================================
  Hits        17845    17845           
  Misses      12519    12519           
Impacted Files Coverage Δ
...ckages/util-config-provider/src/booleanSelector.ts 100.00% <ø> (ø)
...ntsConfig/NodeUseDualstackEndpointConfigOptions.ts 100.00% <100.00%> (ø)
...ndpointsConfig/NodeUseFipsEndpointConfigOptions.ts 100.00% <100.00%> (ø)
.../NodeDisableMultiregionAccessPointConfigOptions.ts 100.00% <100.00%> (ø)
...cket-endpoint/src/NodeUseArnRegionConfigOptions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45d8ee...bbf7037. Read the comment docs.

@trivikr trivikr merged commit 2909c7b into aws:main Nov 5, 2021
@trivikr trivikr deleted the util-config-provider branch November 5, 2021 20:02
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack cannot resolve 'fs' when bundling service client
3 participants