Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node-http-handler set default keep-alive to true #307

Merged
merged 5 commits into from
Jul 25, 2019

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 24, 2019

Issue #, if available:
aws/aws-sdk-js#2571

Description of changes:

  • added keepAlive in NodeHttpOptions
  • modified node-http-handler to accept keepAlive
  • set default keepAlive to true
  • ran node scripts/rebuildClients.ts to update node clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from srchase July 24, 2019 23:10
@trivikr trivikr changed the title feat: node http handler keep alive default feat: node-http-handler set default keep-alive to true Jul 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #307 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   91.35%   91.37%   +0.02%     
==========================================
  Files         266      266              
  Lines        6081     6097      +16     
  Branches     1364     1368       +4     
==========================================
+ Hits         5555     5571      +16     
  Misses        526      526
Impacted Files Coverage Δ
...iceCustomizations/customizationsFromModel/index.ts 100% <ø> (ø) ⬆️
...ackages/node-http-handler/src/node-http-handler.ts 92.72% <100%> (+0.89%) ⬆️
...omizationsFromModel/httpConfigurationProperties.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef92c1...77ce8ee. Read the comment docs.

@srchase srchase self-assigned this Jul 25, 2019
@trivikr trivikr merged commit d709e50 into aws:master Jul 25, 2019
@trivikr trivikr deleted the node-http-handler-keepAlive-default branch July 25, 2019 18:02
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants