fix: honor httpChecksumRequired in sigv2 (#3905)

aws · Oct 5, 2021 · 7cfe19f · 7cfe19f
1 parent af5475f
commit 7cfe19f
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 23 deletions.
diff --git a/.changes/next-release/bugfix-Signer-bb5ba0f7.json b/.changes/next-release/bugfix-Signer-bb5ba0f7.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "Signer",
+  "description": "Fix the bug that httpChecksumRequired trait is not honored in SigV2"
+}
diff --git a/lib/event_listeners.js b/lib/event_listeners.js
@@ -147,7 +147,6 @@ AWS.EventListeners = {
         operation.httpChecksumRequired &&
         req.service.config.computeChecksums &&
         isNonStreamingPayload &&
-        req.service.getSignerClass(req) === AWS.Signers.V4 &&
         !headers['Content-MD5']
       ) {
         var md5 = AWS.util.crypto.md5(body, 'base64');

diff --git a/lib/services/s3.js b/lib/services/s3.js
@@ -430,21 +430,6 @@ AWS.util.update(AWS.S3.prototype, {
     }
   },
 
-  /**
-   * @api private
-   */
-  computableChecksumOperations: {
-    putBucketCors: true,
-    putBucketLifecycle: true,
-    putBucketLifecycleConfiguration: true,
-    putBucketTagging: true,
-    deleteObjects: true,
-    putBucketReplication: true,
-    putObjectLegalHold: true,
-    putObjectRetention: true,
-    putObjectLockConfiguration: true
-  },
-
   /**
    * Checks whether checksums should be computed for the request if it's not
    * already set by {AWS.EventListeners.Core.COMPUTE_CHECKSUM}. It depends on

diff --git a/scripts/region-checker/allowlist.js b/scripts/region-checker/allowlist.js
@@ -37,13 +37,13 @@ var allowlist = {
         254,
         267,
         273,
-        644,
-        646,
-        765,
-        776,
-        777,
-        778,
-        783
+        629,
+        631,
+        750,
+        761,
+        762,
+        763,
+        768
     ]
 };
 

diff --git a/test/event_listeners.spec.js b/test/event_listeners.spec.js