fix: honor httpChecksumRequired in sigv2 #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
commented
Sep 30, 2021
| putObjectRetention: true, | ||
| putObjectLockConfiguration: true | ||
| }, | ||
|
|
There was a problem hiding this comment.
Clear this out because it's not used anywhere.
trivikr
approved these changes
Sep 30, 2021
|
@AllanZhengYP Can you check why CI is failing? |
AllanZhengYP
force-pushed
the
s3-delete-checksum
branch
from
6d8988a
to
d79426d
Compare
trivikr
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3864
The
httpChecksumRequiredused to only applied to SigV4 signers. This removes the extra restrictions, to support users still on deprecated SigV2.Checklist
npm run testpassesnpm run add-change