Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventTimestamp getting lost between httpData and complete events #311

Closed
rjuliano opened this issue Jun 26, 2014 · 3 comments
Closed

eventTimestamp getting lost between httpData and complete events #311

rjuliano opened this issue Jun 26, 2014 · 3 comments

Comments

@rjuliano
Copy link

I noticed that the method getWorkflowExecutionHistory is returning null for all eventTimestamp fields. I'm currently getting the response body from the complete event of the http request.

I added an event listener to the httpData event and saw that eventTimestamp is in fact part of that payload, so somewhere in between httpData and the complete event being emitted, that timestamp is getting lost.

Currently using version 2.0.3 of the js sdk with node.js 0.10.27

@lsegal lsegal closed this as completed in 61f146d Jun 26, 2014
@lsegal
Copy link
Contributor

lsegal commented Jun 26, 2014

Thanks for reporting. It looks like there's a special case where the SDK was failing at timestamp conversion. Automatic conversion of timestamps into dates was a new feature added to 2.x, and it looks like timestamps passed in as numbers was not being correctly handled. The above fix corrects that and should be out with the next release.

lsegal added a commit that referenced this issue Jun 26, 2014
lsegal added a commit that referenced this issue Jun 27, 2014
A previous fix for #311 resolved the parsing of timestamps on JSON
output shapes, but did not generate the correct date. This change
corrects the UNIX timestamp conversion to generate a correct date
for the timestamp.

References #311
@lsegal
Copy link
Contributor

lsegal commented Jun 27, 2014

We added support for this in 2.0.4 (the request would generate a Date object) but it looks like that version was still incorrectly parsing the time. The fix above should generate the correct date for the SWF request. It will be part of the next release.

lsegal added a commit that referenced this issue Jul 8, 2014
@lock
Copy link

lock bot commented Sep 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants