-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eventTimestamp getting lost between httpData and complete events #311
Comments
Thanks for reporting. It looks like there's a special case where the SDK was failing at timestamp conversion. Automatic conversion of timestamps into dates was a new feature added to 2.x, and it looks like timestamps passed in as numbers was not being correctly handled. The above fix corrects that and should be out with the next release. |
We added support for this in 2.0.4 (the request would generate a Date object) but it looks like that version was still incorrectly parsing the time. The fix above should generate the correct date for the SWF request. It will be part of the next release. |
References: #307, #311, amazon-archives/aws-sdk-js-apis#4
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
I noticed that the method getWorkflowExecutionHistory is returning null for all eventTimestamp fields. I'm currently getting the response body from the complete event of the http request.
I added an event listener to the httpData event and saw that eventTimestamp is in fact part of that payload, so somewhere in between httpData and the complete event being emitted, that timestamp is getting lost.
Currently using version 2.0.3 of the js sdk with node.js 0.10.27
The text was updated successfully, but these errors were encountered: