feat: add opt-in support for S3 us-east-1 regional endpoint #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2960 +/- ##
=========================================
+ Coverage 96.99% 97% +<.01%
=========================================
Files 307 308 +1
Lines 9076 9103 +27
Branches 1677 1688 +11
=========================================
+ Hits 8803 8830 +27
Misses 273 273
Continue to review full report at Codecov.
|
trivikr
approved these changes
Nov 22, 2019
test/services/s3.spec.js
Outdated
Comment on lines
3205
to
3207
| expect(['regional', 'legacy'].indexOf( | ||
| request.service.config.s3UsEast1RegionalEndpoint | ||
| ) >= 0).to.equal(true); |
There was a problem hiding this comment.
nit: change to:
expect(request.service.config.s3UsEast1RegionalEndpoint).to.equal(values[i].toLowerCase())
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testpassesnpm run add-changebundle exec rake docs:apiand inspectdoc/latest/index.htmlif documentation is changed