Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent athena.to_iceberg overwrite to delete table in order to preserve Iceberg transactions history #2776

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix: prevent athena.to_iceberg overwrite to delete table in order to preserve Iceberg transactions history #2776

merged 4 commits into from
Apr 22, 2024

Conversation

erwan-simon
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • The "overwrite" mode for the athena.to_iceberg operation deletes the iceberg table, which deletes the Iceberg transactions history. It is unfortunate because in this situation we cannot do Point-In-Time queries after an overwrite. This PR aims to simply delete the data (and not the Iceberg table) before ingesting the new dataset to fix this behavior.

Relates

  • NA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
kukushking
kukushking approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @erwan-simon !

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: d8682ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: d8682ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 6dd28e4 into aws:main Apr 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@kukushking kukushking kukushking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erwan-simon @malachi-constant @kukushking @LeonLuttenberger @jaidisido