Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent athena.to_iceberg overwrite to delete table in order to preserve Iceberg transactions history #2776

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix: prevent athena.to_iceberg overwrite to delete table in order to preserve Iceberg transactions history #2776

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2737af3
fix: prevent athena.to_iceberg overwrite to delete table in order to …
Apr 15, 2024
409b6b7
fix: ruff format
Apr 15, 2024
fdad07f
Merge branch 'main' into main
jaidisido Apr 20, 2024
d8682ad
Merge branch 'main' into main
LeonLuttenberger Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions awswrangler/athena/_write_iceberg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,6 @@ def to_iceberg(
glue_table_settings if glue_table_settings else {},
)

if mode == "overwrite":
catalog.delete_table_if_exists(
database=database, table=table, catalog_id=catalog_id, boto3_session=boto3_session
)

try:
# Create Iceberg table if it doesn't exist
if not catalog.does_table_exist(
Expand Down Expand Up @@ -469,6 +464,20 @@ def to_iceberg(
s3_additional_kwargs=s3_additional_kwargs,
catalog_id=catalog_id,
)
# if mode == "overwrite", delete whole data from table (but not table itself)
elif mode == "overwrite":
delete_sql_statement = f"DELETE FROM {table}"
delete_query_execution_id: str = _start_query_execution(
sql=delete_sql_statement,
workgroup=workgroup,
wg_config=wg_config,
database=database,
data_source=data_source,
encryption=encryption,
kms_key=kms_key,
boto3_session=boto3_session,
)
wait_query(query_execution_id=delete_query_execution_id, boto3_session=boto3_session)

# Create temporary external table, write the results
s3.to_parquet(
Expand Down
Loading