Invalid timestamp value passed to DateTimeResult::fromTimestamp on PHP 8.1 #2327

driesvints · 2021-10-04T18:15:00Z

I've gone though Developer Guide and API reference
I've checked AWS Forums and StackOverflow for answers
I've searched for previous similar issues and didn't find any solution

Describe the bug
When I run the Laravel framework test suite on the upcoming PHP 8.1 release (now in release candidate), related tests to DynamoDB fail from an invalid timestamp issue. These tests are running fine on PHP 7.3 til PHP 8.0. This failure is specifically related to the DateTimeResult class but can origin further up the stacktrace.

https://github.com/laravel/framework/runs/3599702797#step:8:165

Stacktrace

Illuminate\Tests\Integration\Cache\DynamoDbStoreTest::testItemsCanBeAtomicallyAdded
166
Aws\Api\Parser\Exception\ParserException: Invalid timestamp value passed to DateTimeResult::fromTimestamp
167

168
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/DateTimeResult.php:78
169
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/JsonParser.php:51
170
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/JsonParser.php:27
171
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/JsonParser.php:27
172
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/JsonRpcParser.php:49
173
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/JsonRpcParser.php:36
174
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/Api/Parser/Crc32ValidatingParser.php:44
175
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/WrappedHttpHandler.php:125
176
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/WrappedHttpHandler.php:92
177
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:204
178
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:153
179
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/TaskQueue.php:48
180
/home/runner/work/framework/framework/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:158
181
/home/runner/work/framework/framework/vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php:183
182
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:248
183
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:224
184
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:269
185
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:226
186
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:269
187
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:226
188
/home/runner/work/framework/framework/vendor/guzzlehttp/promises/src/Promise.php:62
189
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/AwsClientTrait.php:58
190
/home/runner/work/framework/framework/vendor/aws/aws-sdk-php/src/AwsClientTrait.php:86
191
/home/runner/work/framework/framework/tests/Integration/Cache/DynamoDbStoreTest.php:96
192
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:345
193
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:223
194
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/TestCase.php:75
195
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/Concerns/Testing.php:81
196
/home/runner/work/framework/framework/vendor/orchestra/testbench-core/src/TestCase.php:43
197
/home/runner/work/framework/framework/tests/Integration/Cache/DynamoDbStoreTest.php:23

Version of AWS SDK for PHP?
v3.193.3

Version of PHP (php -v)?
PHP 8.1.0RC2-dev

To Reproduce (observed behavior)
The related test that fails is https://github.com/laravel/framework/blob/8.x/tests/Integration/Cache/DynamoDbStoreTest.php#L49-L55. There's three more but they're all triggering the same issue.

The tests basically translates to the following:

$key = Str::random(6); // Random six character string.

$dynamodb = new DynamoDbClient(/* config */);

// The call below is made 2x...
$this->dynamo->putItem([
    'TableName' => 'cache',
    'Item' => [
        'key' => [
            'S' => $key,
        ],
        'value' => [
            'S' => 'Taylor',
        ],
       'expires_at' => [
            'N' => (string) '1633371128',
        ],
    ],
    'ConditionExpression' => 'attribute_not_exists(#key) OR #expires_at < :now',
    'ExpressionAttributeNames' => [
        '#key' => 'key',
        '#expires_at' => 'expires_at',
    ],
    'ExpressionAttributeValues' => [
        ':now' => [
            'N' => (string) Carbon::now()->getTimestamp(),
        ],
    ],
]);

Expected behavior
I'd expect the behavior to be exactly the same in PHP 8.1

The text was updated successfully, but these errors were encountered:

driesvints · 2021-10-04T18:23:38Z

Upon second view, it could be that these tests are failing because the first one is failing due to #2307. #2316 might fix them all together.

driesvints · 2021-10-09T11:36:06Z

Unfortunately #2316 didn't fix the timestamp issue. I'm at a loss at what's causing this and would appreciate any help with figuring this out...

https://github.com/laravel/framework/pull/39034/checks?check_run_id=3846321821#step:8:127

JackEllis · 2021-10-09T11:52:37Z

This is a complete stab in the dark but is this related: #2053 (comment)

27pchrisl · 2021-10-09T13:54:00Z

Hi @driesvints

Looks the SDK is internally passing a float unix timestamp into gmdate from the DynamoDB JSON response, which throws an exception Implicit conversion from float to int loses precision in 8.1. Probably it should be return new self(gmdate('c', (int)$unixTimestamp)); ?

aws-sdk-php/src/Api/DateTimeResult.php

Line 26 in 79a1020

return new self(gmdate('c', $unixTimestamp));

stephenkhoo · 2021-10-09T14:15:47Z

Hi @driesvints

Looks the SDK is internally passing a float unix timestamp into gmdate from the DynamoDB JSON response, which throws an exception Implicit conversion from float to int loses precision in 8.1. Probably it should be return new self(gmdate('c', (int)$unixTimestamp)); ?

aws-sdk-php/src/Api/DateTimeResult.php

Line 26 in 79a1020

return new self(gmdate('c', $unixTimestamp));

Same finding:

I'm testing on PHP 8.1.0RC4-dev
and after diving through the code, the problem seems to only related to the gmdate.

I even tried comparing using Laravel 8.x with PHP8.0 and Laravel php8.1-fixes with PHP 8.1.0RC4-dev
The $timestamp value loaded are the same into the gmdate('c' $unixTimestamp)

By comparing PHP8.0 running gmdate, it has no problem running with float timestamp

But PHP 8.1.0RC4-dev gmdate refuse to accept float due to the precision loss.

One way is as suggested by @27pchrisl, otherwise might need to look for other date function that didn't loss that precision if that function exists?

clemblanco · 2021-10-11T08:56:32Z

This is the signature of gmdate

gmdate(string $format, ?int $timestamp = null): string

It should be an integer anyway.
I vote for @27pchrisl PR with the cast approach.

driesvints · 2021-10-11T09:03:09Z

@JackEllis @stephenkhoo @27pchrisl @clemblanco wow thanks a lot for your help here! And for figuring that out! I agree, the PR from @27pchrisl looks good. Let's get that in! 💪

github-actions · 2021-10-27T20:47:08Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

driesvints added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2021

27pchrisl mentioned this issue Oct 9, 2021

Fix issue where a float could be passed to gmdate, throwing an exception in PHP 8.1 #2331

Closed

GrahamCampbell mentioned this issue Oct 16, 2021

Fix DateTimeResult on PHP 8.1 #2337

Merged

SamRemis closed this as completed in #2337 Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invalid timestamp value passed to DateTimeResult::fromTimestamp on PHP 8.1 #2327

Invalid timestamp value passed to DateTimeResult::fromTimestamp on PHP 8.1 #2327

driesvints commented Oct 4, 2021 •

edited

Loading

driesvints commented Oct 4, 2021

driesvints commented Oct 9, 2021 •

edited

Loading

JackEllis commented Oct 9, 2021

27pchrisl commented Oct 9, 2021

stephenkhoo commented Oct 9, 2021 •

edited

Loading

clemblanco commented Oct 11, 2021

driesvints commented Oct 11, 2021

github-actions bot commented Oct 27, 2021

Invalid timestamp value passed to DateTimeResult::fromTimestamp on PHP 8.1 #2327

Invalid timestamp value passed to DateTimeResult::fromTimestamp on PHP 8.1 #2327

Comments

driesvints commented Oct 4, 2021 • edited Loading

driesvints commented Oct 4, 2021

driesvints commented Oct 9, 2021 • edited Loading

JackEllis commented Oct 9, 2021

27pchrisl commented Oct 9, 2021

stephenkhoo commented Oct 9, 2021 • edited Loading

clemblanco commented Oct 11, 2021

driesvints commented Oct 11, 2021

github-actions bot commented Oct 27, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

driesvints commented Oct 4, 2021 •

edited

Loading

driesvints commented Oct 9, 2021 •

edited

Loading

stephenkhoo commented Oct 9, 2021 •

edited

Loading