Implements __serialize() and __unserialize() PHP 8.1 magic methods on Aws\Credentials\Credentials class
#2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on Credentials object
9 tasks
|
Hey @SamRemis, any chance we can get this one merged and tagged? |
3 tasks
GrahamCampbell
approved these changes
Oct 4, 2021
|
@ajredniwja @SamRemis heya, I'm sorry I don't want to pressure you but is there any chance we can get this merged and tagged? It's one of the very last things before we can offer a fully working build on PHP 8.1 in Laravel. |
SamRemis
reviewed
Oct 8, 2021
|
@nunomaduro Sorry for the delay in merging :) thanks for opening this |
|
Thanks @SamRemis! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements
__serialize()and__unserialize()PHP 8.1 magic methods onAws\Credentials\Credentialsclass. I've also added a few tests regarding serialization.Fixes #2307.