Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close in_progress response subsegment #125

Merged
merged 11 commits into from
Jun 27, 2019
Merged

Close in_progress response subsegment #125

merged 11 commits into from
Jun 27, 2019

Conversation

luluzhao
Copy link
Contributor

Issue #, if available: Sometimes, when xray sdk traces aws sdk retry calls, the response subsegment will make as in_progress which means we haven't closed it successfully.

Description of changes:
We have to use safeInProgress method in stead of directly getting Inprogress information from a thread unsafe way.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yogiraj07 yogiraj07 self-requested a review June 27, 2019 20:19
@luluzhao luluzhao merged commit 0528083 into aws:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants