-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logic to apply new hardware on tink upgrades #8288
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8288 +/- ##
=======================================
Coverage 73.44% 73.44%
=======================================
Files 578 578
Lines 36165 36165
=======================================
Hits 26561 26561
Misses 7917 7917
Partials 1687 1687 ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: panktishah26 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-0.19 |
@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@panktishah26: new pull request created: #8295 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #8190:
Description of changes:
In previous EKSA upgrade workflows we had operations that were performed on a bootstrap (KinD cluster) after it came up and after CAPI was installed on it.
https://github.com/aws/eks-anywhere/blob/main/pkg/providers/tinkerbell/upgrade.go#L186
https://github.com/aws/eks-anywhere/blob/main/pkg/providers/tinkerbell/upgrade.go#L208
Now looks like these are getting skipped since we have removed the KinD cluster requirement for upgrading. That lead to the above issue. These changes add back the steps for management and workload cluster upgrades.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.