Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Adding logic to apply new hardware on tink upgrades #8295

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #8288

/assign panktishah26

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-0.19@0ad284f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #8295   +/-   ##
===============================================
  Coverage                ?   73.48%           
===============================================
  Files                   ?      589           
  Lines                   ?    37246           
  Branches                ?        0           
===============================================
  Hits                    ?    27369           
  Misses                  ?     8082           
  Partials                ?     1795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member

sp1999 commented Jun 12, 2024

/lgtm

@sp1999
Copy link
Member

sp1999 commented Jun 12, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999
Copy link
Member

sp1999 commented Jun 12, 2024

/ok-to-test

@eks-distro-bot eks-distro-bot merged commit f5b4741 into aws:release-0.19 Jun 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants