chore: replace mock-fs with memfs that works in node20 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/node-20
branch
from
2308845
to
0f72f2d
Compare
|
@Mergifyio backport maintenance/v5.0 maintenance/v5.1 |
mrgrain
force-pushed
the
mrgrain/fix/node-20
branch
from
0f72f2d
to
3c5e5de
Compare
comcalvi
approved these changes
Nov 15, 2023
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jan 10, 2024
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jan 10, 2024
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jan 10, 2024
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jan 10, 2024
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jan 10, 2024
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
#640) # Backport This will backport the following commits from `main` to `maintenance/v5.1`: - [chore: replace mock-fs with memfs that works in node20 (#355)](#355) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) --------- Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
#641) # Backport This will backport the following commits from `main` to `maintenance/v5.0`: - [chore: replace mock-fs with memfs that works in node20 (#355)](#355) <!--- Backport version: 9.3.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) --------- Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are affected by this
mock-fsbug: tschaub/mock-fs#380Seems like there is no activity on the repo recently, so we switch to a new tool.
However
memfsonly works for the test case inassemblies.test.ts.So we keep
mock-fsfor therosetta.test.tstest cases.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.