chore: replace mock-fs with memfs that works in node20 (backport #355) #640
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are affected by this `mock-fs` bug: tschaub/mock-fs#380 Seems like there is no activity on the repo recently, so we switch to a new tool. However `memfs` only works for the test case in `assemblies.test.ts`. So we keep `mock-fs` for the `rosetta.test.ts` test cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit f25a394) # Conflicts: # .projen/deps.json # .projen/tasks.json # package.json # yarn.lock
aws-cdk-automation
force-pushed
the
backport/maintenance/v5.1/pr-355
branch
from
23a0037
to
365abb0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintomaintenance/v5.1:Questions ?
Please refer to the Backport tool documentation