chore(rosetta): _fingerprint() does not attempt to generate new fingerprint
#3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Nov 9, 2021
kaizencc
force-pushed
the
conroy/fingerprint
branch
from
c7edc6d
to
31fa881
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
This PR is meant to do two things: - move `replaceAssembly` to `assembly-utils.ts` in `@jsii/spec`, because it is currently being duplicated in `cdk-generate-synthetic-examples`. This causes problems whenever we try to change `replaceAssembly`, as we did in this [commit](https://github.com/aws/jsii/pull/3669/files), because we will forget to change the function in `cdk-generate-synthetic-examples`. The plan is to have `cdk-generate-synthetic-examples` reference the `replaceAssembly` function in `@jsii/spec` in a separate PR. - finish the effort started in this closed [PR](#3146), where we meant to make sure that we don't re-fingerprint assemblies after they've been changed. It was closed due to staleness. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fingerprintproperty in an assembly is meant to help determinethat an assembly has been changed. However, we do not actually use
that information anywhere. Instead of spending time recalculating a
fingerprint in
_fingerprint(), we now simply update the fingerprintto
**********. This allows us to remove some dependencies as well.In addition, this PR exposes
insertExample()fromindex.tsso thatit can be used elsewhere to insert examples into the assembly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.