chore: move replaceAssembly to @jsii/spec and expose it #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
changed the title
RomainMuller
reviewed
Aug 8, 2022
| /** | ||
| * Replaces the old fingerprint with '***********'. | ||
| * | ||
| * @rmuller says fingerprinting is useless, as we do not actually check |
There was a problem hiding this comment.
That name (rmuller) means nothing here... if you're gonna quote me, at least use my GitHub alias... Also I don't think I've ever said "useless", probably "currently not used", and so it was future-proofing...
There was a problem hiding this comment.
Whoops... somehow it came out of the previous closed PR and I have no idea how I landed on that comment anyway. Will simply remove your alias entirely.
RomainMuller
approved these changes
Aug 9, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to do two things:
replaceAssemblytoassembly-utils.tsin@jsii/spec, because it is currently being duplicated incdk-generate-synthetic-examples. This causes problems whenever we try to changereplaceAssembly, as we did in this commit, because we will forget to change the function incdk-generate-synthetic-examples. The plan is to havecdk-generate-synthetic-examplesreference thereplaceAssemblyfunction in@jsii/specin a separate PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.