feat: auto-detect clusterendpoint for eks #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
|
@ellistarn @jonathan-innis Anything else I should add? |
3 tasks
|
@jonathan-innis I just moved the resolving out of the launchtemplate, the endpoint address is then stored in the settings for the rest of the controllers lifetime. |
6 tasks
Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
woehrl01
requested review from
jonathan-innis
and removed request for
spring1843
bwagner5
requested changes
Feb 9, 2023
bwagner5
reviewed
Feb 9, 2023
|
Oh, I just saw that auto-formatting changed the layout of the markdown quite significantly, I'll revert the change and update only the single line. |
woehrl01
requested review from
bwagner5
and removed request for
jonathan-innis
website/content/en/preview/getting-started/getting-started-with-eksctl/cloudformation.yaml
Outdated
Show resolved
Hide resolved
|
Can you also add a unit test (with mocking on the EKS API) to ensure that we are able to resolve this value if it isn't set? If you need any help figuring out where to go for this, you can ping me on Slack or on GH, happy to help. |
|
@jonathan-innis sure thing, please have a look, if I found the right spots 😄 |
bwagner5
reviewed
Feb 11, 2023
Co-authored-by: Brandon Wagner <bmwagner10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3192
Description
Adds auto-detection of the clusterEndpoint if it's eks, based on the provided clusterName.
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.