Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto discovery permission of cluster endpoint to Karpenter role #2451

Conversation

woehrl01
Copy link
Contributor

@woehrl01 woehrl01 commented Feb 7, 2023

Description

Adds the necessary policy for aws/karpenter-provider-aws#3363

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@woehrl01 woehrl01 changed the title feat: add auto discovery permission of endpoint to karpenter role feat(karpenter): add auto discovery permission of endpoint to karpenter role Feb 7, 2023
@FernandoMiguel
Copy link
Contributor

@woehrl01
Copy link
Contributor Author

woehrl01 commented Feb 7, 2023

@FernandoMiguel Sure, not at all, see: aws-ia/terraform-aws-eks-blueprints#1417

@bryantbiggs bryantbiggs changed the title feat(karpenter): add auto discovery permission of endpoint to karpenter role feat: Add auto discovery permission of cluster endpoint to Karpenter role Feb 15, 2023
@bryantbiggs bryantbiggs merged commit c4a4b8a into terraform-aws-modules:master Feb 15, 2023
antonbabenko pushed a commit that referenced this pull request Feb 15, 2023
## [19.8.0](v19.7.0...v19.8.0) (2023-02-15)

### Features

* Add auto discovery permission of cluster endpoint to Karpenter role ([#2451](#2451)) ([c4a4b8a](c4a4b8a))
@antonbabenko
Copy link
Member

This PR is included in version 19.8.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants