Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master into master-assets #4515

Merged
merged 34 commits into from
Mar 19, 2024
Merged

Merge master into master-assets #4515

merged 34 commits into from
Mar 19, 2024

Conversation

benieric
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gverkes and others added 30 commits March 4, 2024 15:19
@gverkes
fix: make sure gpus are found in local_gpu run (#4384)
7bf6abd 
* fix: make sure gpus are found in local_gpu run

* fix: black formatting

* fix: adjust unit test
@akrishna1995
feat: pin dll version to support python3.11 to the sdk (#4472)
790bd87 
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
@knikure
fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
55293fb
prepare release v2.211.0
84d965c
update development version to v2.211.1.dev0
f2f695a
@samruds
change: Enhance model builder selection logic to include model size (#…
3aa0a56 
…4429)

* change: Enhance model builder selection logic to include model size

* Fix conflicts

* Address PR comments

* fix formatting

* fix formatting of test

* Fix token in tasks.json

* Increase coverage for tests

* fix formatting

* Fix requirements

* Import code instead of importing accelerate

* Fix formatting

* Setup dependencies
@adtian2
change: Upgrade smp to version 2.2 (#4479)
427c7ba 
* upgrading smp to version 2.2

* fixing linting issue

* fixing syntax error with multiline if statement

* upgrading smp to version 2.2

* fixing linting issue

* fixing syntax error with multiline if statement

* fixing formatting

---------

Co-authored-by: Andrew Tian <tinandr@amazon.com>
@sirutBuasai
feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
68fb171 
* update pt2.2 sm training dlc pysdk

* update pt2.2 sm inference dlc pysdk and region list
@knikure
fix: Create custom tarfile extractall util to fix backward compatibil…
df2cc4d 
…ity issue (#4476)

* fix: Create custom tarfile extractall util to fix backward compatibility issue

* Address review comments

* fix logger.error statements
prepare release v2.212.0
f82ceff
update development version to v2.212.1.dev0
907731d
@dbushy727
change: Update tblib constraint (#4452)
fcbd0bf
@benieric
fix: make unit tests compatible with pytest-xdist (#4486)
7fecc33 
* fix: make unit tests compatible with pytest-xdist

* fix failing test
@xiongz945 @samruds
feature: Add overriding logic in ModelBuilder when task is provided (#…
c622a73 
…4460)

* feat: Add Optional task to Model

* Revert "feat: Add Optional task to Model"

This reverts commit fd3e86b.

* Add override logic in ModelBuilder with task provided

* Adjusted formatting

* Add extra unit tests for invalid inputs

* Address PR comments

* Add more test inputs to integration test

* Add model_metadata field to ModelBuilder

* Update doc

* Update doc

* Adjust formatting

---------

Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
@martinRenou
feature: Accept user-defined env variables for the entry-point (#4175)
615a8ad
@qidewenwhen
fix: Move sagemaker pysdk version check after bootstrap in remote job (…
d3a1825 
…#4487)
@benieric
change: enable github actions for PRs (#4489)
07e1b92 
* change: enable github actions for PRs

* Update codebuild-ci.yml

* trigger on pull_request_target

* add source-version-override

* fix permission
@mrudulmn @benieric
feature: Add ModelDataSource and SourceUri support for model package …
b51a613 
…and while registering (#4492)

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
@Captainia @liujiaorr
feat: support JumpStart proprietary models (#4467)
8e400e9 
* feat: add proprietary manifest/specs parsing

add unittests for test_cache

small refactoring

address comments and more unittests

fix linting and fix more tests

fix: pylint

feat: JumpStartModel class for prop models

* remove unused imports and fix docstyle

* fix: remove unused args

* fix: remove unused args

* fix: more unused vars

* fix: slow tests

* fix: unittests

* added more tests to cover some lines

* remove estimator warn check

* chore: address comments re performance

* fix: address comments

* complete list experience and other fixes

* fix: pylint

* add doc utils and fix pylint

* fix: docstyle

* fix: doc

* fix: default payloads

* fix: doc and tags and enums

* fix: jumpstart doc

* rename to open_weights and fix filtering

* update filter name

* doc update

* fix: black

* rename to proprietary model and fix unittests

* address comments

* fix: docstyle and flake8

* address more comments and fix doc

* put back doc utils for future refactoring

* add prop model title in doc

* doc update

---------

Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
@evakravi
chore: emit warning when no instance specific gated training env var …
064378d 
…is available, and raise exception when accept_eula flag is not supplied (#4485)

* fix: raise exception when no instance specific gated training env var available

* chore: raise client exception if accept_eula flag is not set for gated models

* chore: address flake8 errors

* chore: emit warning when instance type is chosen with no gated training artifacts
@evakravi @benieric
fix: sagemaker session region not being used (#4469)
377be87 
* fix: sagemaker session region not being used

* chore: add unit tests

* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments

* chore: use get_region_fallback throughout

* chore: remove unnecessary if statement

* chore: remove unnecessary if statement (2)

---------

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
@ruhanprasad @liujiaorr
fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_dist…
5828ad4 
…ributed distributions (#4480)

* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2

* formatting

* formatting

---------

Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
@akrishna1995
change: split coverage out from testenv in tox.ini (#4495)
1cdd446 
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
@benieric
change: add ci-health checks (#4493)
d15a639
@evakravi
feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
15a40ff
@mufaddal-rohawala
feature: Add support for Streaming Inference (#4497)
fada4bf 
* feature: Add support for Streaming Inference

* fix: codestyle-docs-test

* fix: codestyle-docs-test
@repushko @liujiaorr
Add AutoML -> AutoMLV2 mapper (#4500)
8d22789 
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
@repushko
Skip of tests which are long running and causing the ResourceLimitInU…
b9fbfbd 
…se exception (#4504)
@repushko
Improvement of the tuner documentation (#4506)
c2d5a23
prepare release v2.213.0
5678004
ci and others added 4 commits March 15, 2024 17:31
update development version to v2.213.1.dev0
09fe1c6
@akrishna1995
fix:urge customers to install latest version (#4507)
5a7e99e
@Captainia
fix: list jumpstart models with invalid version strings (#4511)
434cba0 
* fix: list jumpstart models with invalid versions

* docstyle

* docstyle

* pylint

* add more test

* fix
@benieric
fix: skip failing pt test (#4512)
c8d1428 
* fix: skip failing pt test

* black-format
@benieric benieric requested a review from a team as a code owner March 19, 2024 17:57
@benieric benieric requested review from mufaddal-rohawala and removed request for a team March 19, 2024 17:57
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: c8d1428
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@benieric benieric merged commit 3cdefeb into master-assets Mar 19, 2024
42 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala mufaddal-rohawala was automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.