Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combine test and prod permissions for api events #1119

Merged
merged 7 commits into from
Sep 6, 2019

Conversation

ShreyaGangishetty
Copy link

@ShreyaGangishetty ShreyaGangishetty commented Sep 4, 2019

Issue #, if available:
#1102, #337, #285

Description of changes:
removed the extra test permissions for api events

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ShreyaGangishetty ShreyaGangishetty changed the title bugfix: disable test permissions for api events fix: disable test permissions for api events Sep 4, 2019
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #1119 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1119      +/-   ##
==========================================
- Coverage     94.8%   94.8%   -0.01%     
==========================================
  Files           71      71              
  Lines         3487    3486       -1     
  Branches       680     680              
==========================================
- Hits          3306    3305       -1     
  Misses          93      93              
  Partials        88      88
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 89.15% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c39ae...01a924d. Read the comment docs.

@ShreyaGangishetty ShreyaGangishetty changed the title fix: disable test permissions for api events fix: combine test and prod permissions for api events Sep 5, 2019
Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took forever, but I reviewed the changes in the tests as well as the code. This looks good!

@keetonian keetonian assigned jlhood and unassigned keetonian Sep 5, 2019
@jlhood jlhood merged commit b3b9456 into aws:develop Sep 6, 2019
@praneetap praneetap mentioned this pull request Sep 19, 2019
@ShreyaGangishetty ShreyaGangishetty deleted the disable-test-permissions branch March 16, 2020 23:36
@ShreyaGangishetty ShreyaGangishetty restored the disable-test-permissions branch March 16, 2020 23:36
@ShreyaGangishetty ShreyaGangishetty deleted the disable-test-permissions branch March 16, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants