-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: combine test and prod permissions for api events #1119
fix: combine test and prod permissions for api events #1119
Conversation
…odel into disable-test-permissions
Codecov Report
@@ Coverage Diff @@
## develop #1119 +/- ##
==========================================
- Coverage 94.8% 94.8% -0.01%
==========================================
Files 71 71
Lines 3487 3486 -1
Branches 680 680
==========================================
- Hits 3306 3305 -1
Misses 93 93
Partials 88 88
Continue to review full report at Codecov.
|
c747809
to
c1352fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took forever, but I reviewed the changes in the tests as well as the code. This looks good!
…odel into disable-test-permissions
Issue #, if available:
#1102, #337, #285
Description of changes:
removed the extra test permissions for api events
Description of how you validated changes:
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.