misc: bump dependency versions #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ianbotsf
approved these changes
Nov 15, 2023
Comment on lines
+1
to
+5
| { | ||
| "id": "c2af8534-4505-415d-bafa-ab035e261c08", | ||
| "type": "misc", | ||
| "description": "Upgrade dependencies to their latest versions, notably Kotlin 1.9.20" | ||
| } |
There was a problem hiding this comment.
Question: Do we call changes like this "breaking"? Should we minor-version-bump the CRT's sdkVersion?
Comment on lines
126
to
127
| */ | ||
| @OptIn(ExperimentalTime::class) | ||
| private suspend fun connectAllCiphers(url: String) { |
There was a problem hiding this comment.
Question: Did something (IDE, Gradle, etc.) proactively warn you about the unnecessity of this opt-in? Or did you just happen to see this and elect to remove it?
There was a problem hiding this comment.
The IDE warned me. I did a global code search for all @OptIn annotations, and removed the ones which the IDE deemed unnecessary
aajtodd
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bump dependencies to their latest available versions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.