Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: bump dependency versions #83

Merged
merged 4 commits into from
Nov 17, 2023
Merged

misc: bump dependency versions #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d10f4a
Upgrade to Kotlin 1.9.20
lauzadis Nov 1, 2023
1700494
Bump dependency versions
lauzadis Nov 14, 2023
1aa1eaf
changelog
lauzadis Nov 14, 2023
ce4a5d7
Remove opt-ins which are no longer necessary
lauzadis Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/c2af8534-4505-415d-bafa-ab035e261c08.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"id": "c2af8534-4505-415d-bafa-ab035e261c08",
"type": "misc",
"description": "Upgrade dependencies to their latest versions, notably Kotlin 1.9.20"
}
Comment on lines +1 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we call changes like this "breaking"? Should we minor-version-bump the CRT's sdkVersion?

1 change: 0 additions & 1 deletion aws-crt-kotlin/common/test/aws/sdk/kotlin/crt/http/HttpClientConnectionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ class HttpClientConnectionTest : CrtTest() {
* Connect to the URL with all TLS ciphers supported. Throws an exception if the connection attempt fails for
* any reason
*/
@OptIn(ExperimentalTime::class)
private suspend fun connectAllCiphers(url: String) {
Comment on lines 126 to 127
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Did something (IDE, Gradle, etc.) proactively warn you about the unnecessity of this opt-in? Or did you just happen to see this and elect to remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IDE warned me. I did a global code search for all @OptIn annotations, and removed the ones which the IDE deemed unnecessary

withDefaultBootstrap { clientBootstrap ->
TlsCipherPreference.values()
Expand Down
11 changes: 5 additions & 6 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,19 @@ kotlin.mpp.stability.nowarn=true
sdkVersion=0.8.2-SNAPSHOT

# kotlin
kotlinVersion=1.9.10
kotlinVersion=1.9.20
coroutinesVersion=1.7.3

# testing/utility
junitVersion=5.9.2
ktlintVersion=0.48.1
kotestVersion=5.5.4
ktlintVersion=1.0.1
kotestVersion=5.8.0
mockServerVersion=5.15.0

# elasticurl only
kotlinxCliVersion=0.3.2
kotlinxCliVersion=0.3.6

# JVM
crtJavaVersion=0.27.4
crtJavaVersion=0.28.7

# publishing
publishGroupName=aws.sdk.kotlin.crt
Expand Down
Loading