Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Telemetry #109

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Add AWS Telemetry #109

merged 1 commit into from
Feb 28, 2022

Conversation

akartsky
Copy link
Contributor

@akartsky akartsky commented Feb 28, 2022

Merge in AWS Telemetry files from v1.3 branch to main

Documentation to follow

Copy link
Member

@goswamig goswamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting the changes

@surajkota surajkota merged commit 2e8bc14 into awslabs:main Feb 28, 2022
surajkota added a commit that referenced this pull request Mar 8, 2022
**Description of your changes:**
- Bring in changes from #114:
  - TODO item from #109 regarding detailed documentation for telemetry component
  - Changed the name from AWS distribution of Kubeflow to Kubeflow on AWS to be consistent with website and usage tracking documentation
  - Added a section in vanilla Kubeflow readme: `Exposing Kubeflow over Load Balancer` to this [#67](#67) to expose deployment over LoadBalancer.
- adds fixes for a few broken links
- Sync the knative manifest for other deployment options with [vanilla](https://github.com/awslabs/kubeflow-manifests/blob/14c17ff16689dbf70af7fb7971deb7da63105690/docs/deployment/vanilla/kustomization.yaml#L17) corresponding to this [change](kubeflow/manifests#1966). This was a missed in initial PR because of looking at 2 branches to create this one

**Testing**
- links working as expected
- tested kfserving model using steps from #82 for the knative overlay change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants