Documentation updates: usage tracking, vanilla Kubeflow and more #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrkharse
approved these changes
Mar 1, 2022
ryansteakley
approved these changes
Mar 1, 2022
AlexandreBrown
approved these changes
Mar 1, 2022
surajkota
force-pushed
the
v1.3-branch
branch
4 times, most recently
from
88d8c6c
to
788ce3a
Compare
|
Fixed a few broken links, please take another look |
12 tasks
ryansteakley
reviewed
Mar 1, 2022
| - [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html) - A command line tool for interacting with AWS services. | ||
| - [eksctl](https://eksctl.io/introduction/#installation) - A command line tool for working with EKS clusters. | ||
| - [kubectl](https://kubernetes.io/docs/tasks/tools) - A command line tool for working with Kubernetes clusters. | ||
| - [yq](https://mikefarah.gitbook.io/yq) - A command line tool for YAML processing. (For Linux environments, use the [wget plain binary installation](https://mikefarah.gitbook.io/yq/#wget)) |
There was a problem hiding this comment.
Link doesn’t seem to be accurate and suggests going to GitHub page for wget https://github.com/mikefarah/yq/#wget
rrrkharse
approved these changes
Mar 1, 2022
ryansteakley
approved these changes
Mar 1, 2022
|
Good work :) |
surajkota
added a commit
that referenced
this pull request
Mar 8, 2022
**Description of your changes:** - Bring in changes from #114: - TODO item from #109 regarding detailed documentation for telemetry component - Changed the name from AWS distribution of Kubeflow to Kubeflow on AWS to be consistent with website and usage tracking documentation - Added a section in vanilla Kubeflow readme: `Exposing Kubeflow over Load Balancer` to this [#67](#67) to expose deployment over LoadBalancer. - adds fixes for a few broken links - Sync the knative manifest for other deployment options with [vanilla](https://github.com/awslabs/kubeflow-manifests/blob/14c17ff16689dbf70af7fb7971deb7da63105690/docs/deployment/vanilla/kustomization.yaml#L17) corresponding to this [change](kubeflow/manifests#1966). This was a missed in initial PR because of looking at 2 branches to create this one **Testing** - links working as expected - tested kfserving model using steps from #82 for the knative overlay change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Exposing Kubeflow over Load Balancerto this #67 (comment) to expose deployment over LoadBalancer.Testing