Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmg loot fix #145

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Dmg loot fix #145

merged 4 commits into from
Aug 15, 2023

Conversation

OverlordQ
Copy link
Contributor

Changes Proposed:

  • Scales playerDamageRequired based on previous remaining damage and new scaling factor

Issues Addressed:

SOURCE:

Tests Performed:

  • Dmg mob less than 50%, level up, kill => Get Loot
  • Dmg mob more than 50%, level up, kill > Get Loot

How to Test the Changes:

  1. Same as above

@OverlordQ
Update AutoBalance.cpp
234c6a5 
Scale DmgRequired similarly to Creature HP
@OverlordQ
Update AutoBalance.cpp
565bed0 
Fix typo
@OverlordQ
Update AutoBalance.cpp
25ab8b3 
I blame python
@OverlordQ OverlordQ changed the title Dmg loot fix WIP: Dmg loot fix Aug 8, 2023
@OverlordQ
Copy link
Contributor Author

Need to make small modification, it's currently bumping the playerDamageRequired in the wrong direction

@OverlordQ OverlordQ changed the title WIP: Dmg loot fix Dmg loot fix Aug 8, 2023
@OverlordQ
Copy link
Contributor Author

Alright, I believe I've fixed the math.

@pangolp
Copy link
Contributor

pangolp commented Aug 8, 2023

I put the tests to run, they should be automatic, but anything that doesn't run alerts me.

pangolp
pangolp approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pangolp pangolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pangolp pangolp merged commit c7693f7 into azerothcore:master Aug 15, 2023
1 check passed
@danieldfischer danieldfischer mentioned this pull request Sep 11, 2023
Closed
1 task
trickerer added a commit to trickerer/mod-autobalance that referenced this pull request Sep 12, 2023
@trickerer
Dmg loot fix (azerothcore#145)
190e67d 
* Update AutoBalance.cpp

Scale DmgRequired similarly to Creature HP

* Update AutoBalance.cpp

Fix typo

* Update AutoBalance.cpp

I blame python

* Update AutoBalance.cpp

Fix Math

(cherry picked from commit c7693f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pangolp pangolp pangolp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: You don't receive credit when triggering a creature update.
2 participants
@OverlordQ @pangolp