Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matches pattern cleanup #5826

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Matches pattern cleanup #5826

merged 3 commits into from
Jun 6, 2017

Conversation

jridgewell
Copy link
Member

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

We have matchesPattern duplicated in babel-types and babel-traverse. This dedupes to the babel-types version, and reimplements it to make it understandable.

@jridgewell jridgewell added the PR: Polish 💅 A type of pull request used for our changelog categories label Jun 6, 2017
@mention-bot
Copy link

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zertosh, @hzoo and @gaearon to be potential reviewers.

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #5826 into 7.0 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              7.0    #5826     +/-   ##
=========================================
+ Coverage   84.95%   85.06%   +0.1%     
=========================================
  Files         284      284             
  Lines        9933     9904     -29     
  Branches     2781     2774      -7     
=========================================
- Hits         8439     8425     -14     
+ Misses        982      980      -2     
+ Partials      512      499     -13
Impacted Files Coverage Δ
packages/babel-traverse/src/path/introspection.js 46.52% <100%> (+1.28%) ⬆️
packages/babel-types/src/index.js 87.84% <100%> (+4.23%) ⬆️
packages/babel-helper-fixtures/src/index.js 71.62% <0%> (-4.06%) ⬇️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-1.73%) ⬇️
packages/babel-traverse/src/path/modification.js 72.11% <0%> (-0.97%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-types/src/definitions/es2015.js 96.15% <0%> (-0.52%) ⬇️
packages/babel-types/src/definitions/core.js 98.21% <0%> (-0.32%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.63% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123dce5...dcc9f9b. Read the comment docs.

@hzoo hzoo merged commit 5cc1cbf into babel:7.0 Jun 6, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants