[skip ci] - Moving do expression to stage 1 #6943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
approved these changes
Dec 1, 2017
xtuc
requested changes
Dec 1, 2017
There was a problem hiding this comment.
It's still used here https://github.com/rajzshkr/babel/blob/3d7703bf91824481a2296c4b1e2af6f8957ff96c/packages/babel-preset-stage-0/src/index.js#L3
And you need to move this in the stage-1 preset.
Btw the tests didn't catch that.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6069/ |
…oving-do-stage1 # Conflicts: # packages/babel-preset-stage-1/package.json
I didnt see any test cases to catch this |
danez
approved these changes
Dec 2, 2017
hzoo
added
the
PR: Spec Compliance 👓
Sorry I wasn't clear, I meant by this that there's no tests on our presets. Testing the transformations would be too difficult to maintain I think but we can at least test that they are correct Babel plugins. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the spec, we have to move
do expressionto stage 1 https://github.com/tc39/proposals#stage-1