Optimize async to generator #8267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can reuse the step function, avoiding a closure on every invocation.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8498/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8496/ |
loganfsmyth
reviewed
Jul 5, 2018
| @@ -238,30 +238,35 @@ helpers.asyncGeneratorDelegate = () => template.program.ast` | |||
| `; | |||
|
|
|||
| helpers.asyncToGenerator = () => template.program.ast` | |||
| function step(gen, resolve, reject, _next, _throw, key, arg) { | |||
There was a problem hiding this comment.
I think it'd be worth giving this a more verbose name if we're splitting it out. Thoughts?
nicolo-ribaudo
approved these changes
Jul 5, 2018
Andarist
reviewed
Jul 5, 2018
|
|
||
| _next(); | ||
| _next(undefined); |
There was a problem hiding this comment.
any particular reason for this explicit undefined?
There was a problem hiding this comment.
Monomorphic calls. Probably negligible.
There was a problem hiding this comment.
is arg length important for monomorphism? always thought solely about shapes in this regard
hzoo
added
the
PR: Internal 🏠
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reuse the step function, avoiding a closure on every invocation.