Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paragraph Type Clone function #149

Closed
yorkshire-pudding opened this issue Nov 29, 2022 · 6 comments · Fixed by #150
Closed

Add Paragraph Type Clone function #149

yorkshire-pudding opened this issue Nov 29, 2022 · 6 comments · Fixed by #150
Labels
enhancement New feature or request has pr Has a PR or branch for testing.

Comments

@yorkshire-pudding
Copy link
Contributor

yorkshire-pudding commented Nov 29, 2022

As a site builder
I want to be able to clone a paragraph type
So that I can easily create a variant from the same field and display basis without having to recreate these manually.

I started off doing this as a new module but realised that the best place to put the link would be in the drop menu, rather than having as a link on the page. The module that inspired this was Content Type Clone and much methodology was derived from that but it is slightly different. That module rebuilt the content type overview page which I don't think is ideal for paragraphs as it means any changes to that page need to be done in two places.

I realised it wouldn't take too much work to put as a function in Paragraphs and that it would make the user experience better.

So here is the question, @laryn, should it be an enhancement (PR below) to Paragraphs or its own module?

Own module: https://github.com/yorkshire-pudding/paragraphs_type_clone
PR : #150

@laryn
Copy link
Member

laryn commented Nov 29, 2022

@yorkshire-pudding This is great -- I think it is a valuable addition. Let me think on it a little as to whether it should be merged directly into Paragraphs. I'll also try to make some time to test the PR this week.

@yorkshire-pudding
Copy link
Contributor Author

@laryn - any thoughts?

@laryn
Copy link
Member

laryn commented Dec 10, 2022

@yorkshire-pudding Sorry, I'm running behind on testing this. I still have it bookmarked at the top of my list.

@yorkshire-pudding
Copy link
Contributor Author

@laryn - this PR and the separate module now clone permissions if they exist (i.e. if Paragraphs Type Permissions is enabled).

@laryn
Copy link
Member

laryn commented Dec 19, 2022

@yorkshire-pudding I've done some functional testing and it's looking good. I'm going to look through the code one more time this week.

@yorkshire-pudding yorkshire-pudding removed the question Further information is requested label Dec 20, 2022
@laryn
Copy link
Member

laryn commented Dec 22, 2022

Thanks for hanging in there on all those back-and-forths in the review @yorkshire-pudding -- merged! This will be a nice addition. And thank @argiepiano for looking things over with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request has pr Has a PR or branch for testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants