Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #62: organize buttons into a dropdown #180

Merged
merged 11 commits into from
Jun 25, 2024

Conversation

herbdool
Copy link
Contributor

@herbdool herbdool commented Jun 4, 2024

Fixes #62.

Alternative that puts buttons other than "Edit" into a dropdown. The dropdown is custom since there's nothing in core to help with dropdowns that contain buttons.

@herbdool herbdool changed the title Issue 62alt Issue #62: organize buttons into a dropdown Jun 4, 2024
@herbdool
Copy link
Contributor Author

@irinaz have you had a chance to test this? Would be good to have a go at this so it's easier for @laryn to review.

@irinaz
Copy link

irinaz commented Jun 14, 2024

@herbdool @laryn look great to me. I tested it with https://github.com/backdrop-contrib/paragraphs_aplenty and I think that this change can be merged as is.

@irinaz
Copy link

irinaz commented Jun 14, 2024

@herbdool , there was small styling difference for unpublish/remove links for cards/card , but I think that new display is much better even with this glitch.

Screenshot 2024-06-14 at 2 05 41 PM Screenshot 2024-06-14 at 2 07 30 PM

Thank you so much for making it work!!

@herbdool
Copy link
Contributor Author

@irinaz for testing.

I can't recreate that issue you've got with the dropdown. This is what I see:

Screenshot from 2024-06-15 10-36-22

Did you test on a fresh install? It's best to do it clean to ensure there's not something else interfering.

@irinaz
Copy link

irinaz commented Jun 15, 2024

@herbdool , I tested on another site and I see what you see.
@laryn , I think that this is ready for merge :)

@laryn
Copy link
Member

laryn commented Jun 25, 2024

@herbdool Can you check/test this commit and let me know what you think?
92c4806

@herbdool
Copy link
Contributor Author

I'll check it soon.

@herbdool
Copy link
Contributor Author

@laryn this works well for me. Thanks for fixing the JS! I suggested a couple tweaks to file location, etc. but I think it's more or less ready.

@laryn laryn merged commit bfb0dfc into backdrop-contrib:1.x-1.x Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Paragraphs item action buttons to top right in a drop-down style.
3 participants