Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve package version dynamically #220

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Feb 24, 2022

This allows us to remove the bumpversion logic for updating __version__. It's also the first step towards replacing bumpversion with poetry version.

@disrupted disrupted self-assigned this Feb 24, 2022
@VictorKuenstler
Copy link
Collaborator

We could display the version in the following also in the frontend. This could make error investigations much easier. This would be a separate issue + PR. What do you think?

@disrupted
Copy link
Member Author

disrupted commented Feb 25, 2022

We could display the version in the following also in the frontend. This could make error investigations much easier. This would be a separate issue + PR. What do you think?

I've thought about that too, although it doesn't depend on this change.
And I agree, we should definitely have a user-facing modal that shows the current version. This could be part of the settings menu for example.
edit: I've opened an issue for it #221

@disrupted disrupted merged commit aded321 into main Mar 7, 2022
@disrupted disrupted deleted the refactor/dynamic-package-version branch March 7, 2022 09:27
disrupted added a commit that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants