Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install streams_explorer package after dependencies #226

Merged
merged 14 commits into from
Mar 21, 2022
Merged

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Mar 16, 2022

This fixes an issue introduced by #220, where the Docker image would fail to launch because importlib can't find the streams_explorer package. This is now fixed by installing the actual package through pip rather than just copying the module folder into the Docker image.
Once poetry 1.2.0 is released we might be able to transition to poetry add -e, which is a new feature currently in pre-release.

Additionally this gets rid of a workaround which was used to copy the README from repository root to the Python package before release. Instead, it is now located there and symlinked to root. The presentation on GitHub is unaffected by this change.

@disrupted disrupted self-assigned this Mar 16, 2022
@disrupted disrupted marked this pull request as ready for review March 16, 2022 16:55
@VictorKuenstler
Copy link
Collaborator

Maybe we should think about handling the Readme for Python package as a separate Readme because the content of the overall Readme might be confusing. 🤔 But, of course, that would be a separate PR.

Copy link
Collaborator

@VictorKuenstler VictorKuenstler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disrupted
Copy link
Member Author

Maybe we should think about handling the Readme for Python package as a separate Readme because the content of the overall Readme might be confusing. 🤔 But, of course, that would be a separate PR.

good point! Then again, the Python package is probably always used with the frontend. We can think of slimming it down somewhat for PyPI.

@VictorKuenstler
Copy link
Collaborator

good point! Then again, the Python package is probably always used with the frontend. We can think of slimming it down somewhat for PyPI.

Yep exactly. Highlighting the purpose of the Python Package could be good. This could make it easier to understand why and when to use it.

@disrupted disrupted merged commit 0b2de6f into main Mar 21, 2022
@disrupted disrupted deleted the fix/package-import branch March 21, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants