-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install streams_explorer package after dependencies #226
Conversation
pip install -e seems to require the virtualenv package to be installed even when we are not using one
7d46ac1
to
f966fe0
Compare
Maybe we should think about handling the Readme for Python package as a separate Readme because the content of the overall Readme might be confusing. 🤔 But, of course, that would be a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
good point! Then again, the Python package is probably always used with the frontend. We can think of slimming it down somewhat for PyPI. |
Yep exactly. Highlighting the purpose of the Python Package could be good. This could make it easier to understand why and when to use it. |
This fixes an issue introduced by #220, where the Docker image would fail to launch because importlib can't find the
streams_explorer
package. This is now fixed by installing the actual package through pip rather than just copying the module folder into the Docker image.Once poetry 1.2.0 is released we might be able to transition to
poetry add -e
, which is a new feature currently in pre-release.Additionally this gets rid of a workaround which was used to copy the README from repository root to the Python package before release. Instead, it is now located there and symlinked to root. The presentation on GitHub is unaffected by this change.