Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html styling #88

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Fix html styling #88

merged 1 commit into from
Jul 23, 2022

Conversation

prisae
Copy link
Collaborator

@prisae prisae commented Jul 22, 2022

Fixes the bad html styling for dark themes. The fix is done by simply removing all hard-coded colours, and leaving it up to the theme to decide on colours.

I tried a few of the Jupyter themes available:
2022-07-22-02

I hope this would be OK with you @akaszynski (pinging you as you started with #82).

Closes #62

@codecov-commenter
Copy link

Codecov Report

Merging #88 (f76b387) into main (999d9ca) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   87.15%   87.32%   +0.16%     
==========================================
  Files           4        4              
  Lines         366      363       -3     
==========================================
- Hits          319      317       -2     
+ Misses         47       46       -1     

@akaszynski
Copy link
Collaborator

This is probably the better solution.
@banesullivan, I’ll merge this if you’re fine with it.

@prisae prisae mentioned this pull request Jul 23, 2022
@akaszynski akaszynski merged commit dcb53ff into main Jul 23, 2022
@akaszynski akaszynski deleted the colours branch July 23, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color scheme in Jupyter Darkmode
3 participants