Improve HTML formatting #82
Conversation
|
I like the colours, thanks @akaszynski I would be a bit more cautious personally for the two-column change. It is quite a change. Could it be a keyword-change instead, eg |
| @@ -192,7 +195,7 @@ def __init__( | |||
| optional = ['numpy', 'scipy', 'IPython', 'matplotlib', 'scooby'] | |||
|
|
|||
| PythonInfo.__init__(self, additional=additional, core=core, optional=optional, sort=sort) | |||
| self.ncol = int(ncol) | |||
| self.ncol = 2 | |||
There was a problem hiding this comment.
I don't think ncol should be hardcoded here, doesn't render this the ncol input parameter useless?
| @@ -269,59 +272,43 @@ def colspan(html, txt, ncol, nrow): | |||
| elif nrow % 2 == 0: | |||
| html += "background-color: #ddd;" | |||
| html += border + " colspan='" | |||
| html += str(2 * ncol) + "'>%s</td>\n" % txt | |||
| html += f"{ncol}'>{txt}</td>\n" | |||
There was a problem hiding this comment.
This changes the ncol behaviour. ncol before meant than in a column of ncol there was one column for package names and and one column for version numbers. Now it means that ncol has to account for package names and version numbers separately.
|
Could we split your two points, (1) remove hard-coded table color and (2) force two columns, into two separate PR's? I think (1) would be just ready to go, whereas (2) I am personally against, or it would need at least some discussion and thinking and agreeing IMHO. |
|
Is it OK to close this one @akaszynski in favour of #88 and potentially #89 ? |
Absolutely. #88 is better. |
Resolve #62 by removing the hard-coded table color.
Improves HTML report by forcing two columns to make the package listing more readable.