Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a compact layout for ncol=1 #89

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Introduce a compact layout for ncol=1 #89

merged 3 commits into from
Jul 23, 2022

Conversation

prisae
Copy link
Collaborator

@prisae prisae commented Jul 22, 2022

My proposition as an alternative to #82 @akaszynski - what do you think?

It does the following:

  • If ncol=1, it left-aligns everything.
  • It adds a new max-width parameter, with which the user can control the max-width of the table.
  • I tried to include all the other little cleaning-up bits you put into Improve HTML formatting #82.

An example how this "compact" layout looks:
2022-07-22-01

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #89 (0c2708b) into main (999d9ca) will decrease coverage by 0.22%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   87.15%   86.93%   -0.23%     
==========================================
  Files           4        4              
  Lines         366      375       +9     
==========================================
+ Hits          319      326       +7     
- Misses         47       49       +2     

@prisae prisae mentioned this pull request Jul 23, 2022
@akaszynski
Copy link
Collaborator

Looks way better @prisae, this is good to go provided CI passes post-merge with main.

@prisae prisae merged commit 4c95f5a into main Jul 23, 2022
@prisae prisae deleted the layout branch July 23, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants